-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Skip loading pk index for sorted segment in loader #39437
enhance: Skip loading pk index for sorted segment in loader #39437
Conversation
Related to milvus-io#39339 Previous PR milvus-io#39389 only skips append index into segment Also related to milvus-io#39428 Signed-off-by: Congqi Xia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39437 +/- ##
=======================================
Coverage 80.97% 80.98%
=======================================
Files 1408 1408
Lines 198569 198580 +11
=======================================
+ Hits 160797 160821 +24
+ Misses 32100 32087 -13
Partials 5672 5672
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #39339
Previous PR #39389 only skips append index into segment
Also related to #39428