Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Skip loading pk index for sorted segment in loader #39437

Conversation

congqixia
Copy link
Contributor

Related to #39339
Previous PR #39389 only skips append index into segment

Also related to #39428

Related to milvus-io#39339
Previous PR milvus-io#39389 only skips append index into segment

Also related to milvus-io#39428

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 20, 2025
@sre-ci-robot sre-ci-robot requested review from aoiasd and yah01 January 20, 2025 06:30
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (cb959cd) to head (67ca4d9).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39437   +/-   ##
=======================================
  Coverage   80.97%   80.98%           
=======================================
  Files        1408     1408           
  Lines      198569   198580   +11     
=======================================
+ Hits       160797   160821   +24     
+ Misses      32100    32087   -13     
  Partials     5672     5672           
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.92% <0.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 66.95% <0.00%> (-0.72%) ⬇️

... and 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 20, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 20, 2025
…9438)

Cherry pick from master
pr: #39437

Related to #39339
Previous PR #39389 only skips append index into segment

Also related to #39428

Signed-off-by: Congqi Xia <[email protected]>
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fb5761a into milvus-io:master Jan 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants