Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]add some apis in Restful #39425

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

smellthemoon
Copy link
Contributor

pr: #39105
issue: #38709

lixinguo added 2 commits January 20, 2025 10:15
Signed-off-by: lixinguo <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 20, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2025
Copy link
Contributor

mergify bot commented Jan 20, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (f704e3e) to head (c56816b).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 91.01% 7 Missing and 1 partial ⚠️
...nternal/distributed/proxy/httpserver/request_v2.go 28.57% 5 Missing ⚠️
internal/distributed/proxy/httpserver/utils.go 93.18% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39425       +/-   ##
===========================================
+ Coverage   69.49%   81.00%   +11.51%     
===========================================
  Files         300     1404     +1104     
  Lines       26767   197703   +170936     
===========================================
+ Hits        18601   160144   +141543     
- Misses       8166    31934    +23768     
- Partials        0     5625     +5625     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.49% <ø> (+<0.01%) ⬆️
Go 82.97% <88.57%> (∅)
Files with missing lines Coverage Δ
internal/distributed/proxy/httpserver/utils.go 84.76% <93.18%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 81.61% <28.57%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 92.84% <91.01%> (ø)

... and 1102 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 20, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants