Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry pick warmup async #39402

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix: cherry pick warmup async #39402

merged 4 commits into from
Jan 20, 2025

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 17, 2025

related pr: #38690
issue: #38692

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 17, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sunby added 2 commits January 17, 2025 17:59
Signed-off-by: sunby <[email protected]>
Signed-off-by: sunby <[email protected]>
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 20, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor

foxspy commented Jan 20, 2025

/run-cpu-e2e

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (b6be11c) to head (c10d4a5).
Report is 5 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment.go 89.18% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39402      +/-   ##
==========================================
+ Coverage   80.41%   80.45%   +0.03%     
==========================================
  Files        1080     1080              
  Lines      169974   170012      +38     
==========================================
+ Hits       136687   136776      +89     
+ Misses      28784    28743      -41     
+ Partials     4503     4493      -10     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator_data.go 88.25% <100.00%> (+0.47%) ⬆️
internal/querynodev2/segments/pool.go 94.11% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 71.57% <100.00%> (+0.74%) ⬆️
internal/querynodev2/segments/segment.go 68.33% <89.18%> (+0.58%) ⬆️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 20, 2025
@sre-ci-robot sre-ci-robot merged commit 2ead5d6 into milvus-io:2.4 Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants