Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]Add schema update time verification for insert and upsert to use cache #39382

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

fix e2e test error

4c218cb
Select commit
Loading
Failed to load commit list.
Open

enhance: [2.5]Add schema update time verification for insert and upsert to use cache #39382

fix e2e test error
4c218cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

81.00% (target 77.00%)

View this Pull Request on Codecov

81.00% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (6f9f840) to head (4c218cb).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task_insert.go 50.00% 6 Missing and 2 partials ⚠️
internal/proxy/task_upsert.go 50.00% 6 Missing and 2 partials ⚠️
internal/rootcoord/alter_collection_task.go 50.00% 4 Missing ⚠️
pkg/util/merr/utils.go 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39382   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files        1404     1404           
  Lines      197578   197637   +59     
=======================================
+ Hits       160047   160100   +53     
- Misses      31916    31926   +10     
+ Partials     5615     5611    -4     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.97% <67.16%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/metastore/model/collection.go 84.51% <100.00%> (+0.41%) ⬆️
internal/proxy/impl.go 83.85% <100.00%> (+<0.01%) ⬆️
internal/proxy/meta_cache.go 90.66% <100.00%> (+0.02%) ⬆️
internal/proxy/task.go 80.65% <100.00%> (+0.01%) ⬆️
internal/rootcoord/create_collection_task.go 90.47% <100.00%> (+0.01%) ⬆️
internal/rootcoord/root_coord.go 90.14% <100.00%> (+<0.01%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 84.19% <75.00%> (-0.09%) ⬇️
internal/rootcoord/alter_collection_task.go 53.30% <50.00%> (-0.11%) ⬇️
internal/proxy/task_insert.go 72.99% <50.00%> (-1.67%) ⬇️
... and 1 more

... and 27 files with indirect coverage changes