-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Folders are also considered for WalkWithObjects to adhere bulk insert failure on using GCS buckets #39352
Conversation
@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
8644c8f
to
88af81a
Compare
Signed-off-by: gifi-siby <[email protected]>
88af81a
to
7766fb6
Compare
@gifi-siby go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39352 +/- ##
==========================================
- Coverage 81.03% 81.03% -0.01%
==========================================
Files 1407 1407
Lines 198527 198530 +3
==========================================
- Hits 160885 160884 -1
Misses 31983 31983
- Partials 5659 5663 +4
|
@xiaofan-luan commented in @39150 that the implementation of gcp_native_object storage can be wrong because the test result of it is different from minio_object_storage test and suggested to modify gcp_native_object_storage to follow the behaviour of minio storage. Replied here: #39150#issuecomment-2594735364 But we can stimulate the behaviour of azure in GCS. So, I'll modify the test scenarios according to azure. |
rerun go-sdk |
@gifi-siby go-sdk check failed, comment |
rerun go-sdk |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gifi-siby, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related task: #39134
Previous PR: #39150