Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support restful & go sdk for Int8Vector #39278

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jan 15, 2025

Issue: #38666

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/test sig/testing labels Jan 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (7476eb3) to head (a2fc632).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/proxy/httpserver/utils.go 68.25% 15 Missing and 5 partials ⚠️
client/column/vector.go 77.77% 4 Missing ⚠️
client/entity/field.go 0.00% 4 Missing ⚠️
client/column/columns.go 85.00% 2 Missing and 1 partial ⚠️
client/row/data.go 62.50% 2 Missing and 1 partial ⚠️
...ernal/distributed/proxy/httpserver/wrap_request.go 90.00% 2 Missing and 1 partial ⚠️
client/entity/vectors.go 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39278       +/-   ##
===========================================
+ Coverage   69.56%   80.92%   +11.36%     
===========================================
  Files         300     1408     +1108     
  Lines       26986   199051   +172065     
===========================================
+ Hits        18773   161087   +142314     
- Misses       8213    32254    +24041     
- Partials        0     5710     +5710     
Components Coverage Δ
Client 79.49% <78.94%> (∅)
Core 69.56% <ø> (-0.01%) ⬇️
Go 82.84% <75.26%> (∅)
Files with missing lines Coverage Δ
client/column/conversion.go 96.53% <100.00%> (ø)
client/milvusclient/write_options.go 65.58% <100.00%> (ø)
client/row/schema.go 91.91% <100.00%> (ø)
client/entity/vectors.go 68.18% <66.66%> (ø)
client/column/columns.go 85.82% <85.00%> (ø)
client/row/data.go 67.15% <62.50%> (ø)
...ernal/distributed/proxy/httpserver/wrap_request.go 94.76% <90.00%> (ø)
client/column/vector.go 81.39% <77.77%> (ø)
client/entity/field.go 57.30% <0.00%> (ø)
internal/distributed/proxy/httpserver/utils.go 84.14% <68.25%> (ø)

... and 1102 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_support_int8_vector_sdk branch from 5070779 to 3747fd7 Compare January 15, 2025 07:05
Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_support_int8_vector_sdk branch from 3747fd7 to f824553 Compare January 21, 2025 03:10
Copy link
Contributor

mergify bot commented Jan 21, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 21, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_support_int8_vector_sdk branch 2 times, most recently from f54fe60 to b4b54f9 Compare January 23, 2025 07:31
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 23, 2025
@cydrain cydrain force-pushed the caiyd_38666_support_int8_vector_sdk branch from b4b54f9 to a2fc632 Compare January 23, 2025 09:37
Copy link
Contributor

mergify bot commented Jan 23, 2025

@cydrain cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Jan 24, 2025

/run-cpu-e2e

@cydrain
Copy link
Contributor Author

cydrain commented Jan 24, 2025

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Jan 24, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Jan 24, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 24, 2025
@cydrain
Copy link
Contributor Author

cydrain commented Jan 24, 2025

/hold

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain
Copy link
Contributor Author

cydrain commented Jan 24, 2025

/unhold

@sre-ci-robot sre-ci-robot merged commit f32830e into milvus-io:master Jan 24, 2025
19 of 20 checks passed
@cydrain cydrain deleted the caiyd_38666_support_int8_vector_sdk branch January 24, 2025 09:07
@cydrain cydrain mentioned this pull request Feb 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants