Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to replicate import msg #39171

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 11, 2025

No description provided.

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 11, 2025
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/internal-api labels Jan 11, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 11, 2025
Copy link
Contributor

mergify bot commented Jan 11, 2025

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot removed the needs-dco DCO is missing in this pull request. label Jan 23, 2025
@SimFG SimFG force-pushed the master branch 4 times, most recently from 0b05cbc to 41021c2 Compare January 27, 2025 11:22
@SimFG
Copy link
Contributor Author

SimFG commented Jan 27, 2025

rerun ut

3 similar comments
@SimFG
Copy link
Contributor Author

SimFG commented Feb 2, 2025

rerun ut

@SimFG
Copy link
Contributor Author

SimFG commented Feb 2, 2025

rerun ut

@SimFG
Copy link
Contributor Author

SimFG commented Feb 5, 2025

rerun ut

@SimFG SimFG force-pushed the master branch 2 times, most recently from a2637d2 to 4cfc46e Compare February 5, 2025 06:36
@SimFG
Copy link
Contributor Author

SimFG commented Feb 5, 2025

rerun ut

@SimFG SimFG force-pushed the master branch 3 times, most recently from 444183b to 38a4812 Compare February 5, 2025 11:12
@SimFG
Copy link
Contributor Author

SimFG commented Feb 5, 2025

rerun ut

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 70.73579% with 175 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (82f9689) to head (93de946).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_import.go 70.17% 43 Missing and 8 partials ⚠️
...ode/server/flusher/flusherimpl/msg_handler_impl.go 0.00% 35 Missing ⚠️
...amingcoord/server/broadcaster/broadcast_manager.go 34.78% 12 Missing and 3 partials ⚠️
internal/datacoord/compaction_trigger_v2.go 82.50% 10 Missing and 4 partials ⚠️
...nternal/flushcommon/pipeline/flow_graph_dd_node.go 0.00% 14 Missing ⚠️
internal/datacoord/services.go 56.00% 8 Missing and 3 partials ⚠️
pkg/streaming/util/message/adaptor/message.go 0.00% 9 Missing ⚠️
internal/datacoord/import_util.go 57.14% 4 Missing and 2 partials ⚠️
pkg/mq/msgstream/msg_for_import.go 81.25% 4 Missing and 2 partials ⚠️
internal/flushcommon/util/msg_handler.go 0.00% 5 Missing ⚠️
... and 3 more

❌ Your patch check has failed because the patch coverage (70.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39171       +/-   ##
===========================================
+ Coverage   69.39%   81.41%   +12.02%     
===========================================
  Files         302     1178      +876     
  Lines       27070   177693   +150623     
===========================================
+ Hits        18785   144676   +125891     
- Misses       8285    27150    +18865     
- Partials        0     5867     +5867     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core ∅ <ø> (∅)
Go 81.51% <70.73%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 72.23% <100.00%> (ø)
internal/datacoord/compaction_policy_l0.go 97.56% <100.00%> (ø)
internal/datacoord/import_checker.go 78.89% <100.00%> (ø)
internal/datacoord/import_job.go 100.00% <ø> (ø)
internal/datacoord/import_meta.go 94.58% <100.00%> (ø)
internal/datanode/data_node.go 75.09% <100.00%> (ø)
internal/distributed/streaming/test_streaming.go 100.00% <100.00%> (ø)
internal/flushcommon/broker/broker.go 100.00% <ø> (ø)
internal/flushcommon/broker/datacoord.go 96.77% <100.00%> (ø)
internal/flushcommon/util/util.go 26.66% <ø> (ø)
... and 19 more

... and 1451 files with indirect coverage changes

@SimFG SimFG force-pushed the master branch 6 times, most recently from f297e54 to 6319b98 Compare February 7, 2025 06:22
@SimFG SimFG force-pushed the master branch 2 times, most recently from 266831d to 49a4625 Compare February 7, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file area/internal-api area/test dco-passed DCO check passed. do-not-merge/missing-related-issue do-not-merge/work-in-progress Don't merge even CI passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants