Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5][cp] speed up search iterator stage 1 #38678

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Dec 24, 2024

pr: #37947
issue: #37548

Signed-off-by: Patrick Weizhi Xu [email protected]
(cherry picked from commit 9016c4a)

@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file size/XXL Denotes a PR that changes 1000+ lines. labels Dec 24, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@PwzXxm

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@PwzXxm PwzXxm changed the title [2.5][cp] enhance: speed up search iterator stage 1 enhance: [2.5][cp] speed up search iterator stage 1 Dec 24, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 88.62434% with 43 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (f441ccd) to head (ee57cee).
Report is 9 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/query/SearchOnSealed.cpp 36.84% 12 Missing ⚠️
internal/core/src/query/CachedSearchIterator.cpp 95.90% 7 Missing ⚠️
internal/proxy/search_util.go 90.14% 5 Missing and 2 partials ⚠️
internal/core/src/query/SearchBruteForce.cpp 80.95% 4 Missing ⚠️
internal/core/src/query/SearchOnGrowing.cpp 42.85% 4 Missing ⚠️
internal/core/src/query/SearchOnIndex.cpp 42.85% 4 Missing ⚠️
internal/core/src/index/Utils.cpp 88.23% 2 Missing ⚠️
internal/core/src/query/PlanProto.cpp 75.00% 2 Missing ⚠️
internal/core/src/query/CachedSearchIterator.h 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38678      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1381     1383       +2     
  Lines      195157   195474     +317     
==========================================
+ Hits       158206   158461     +255     
- Misses      31392    31451      +59     
- Partials     5559     5562       +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.47% <86.81%> (+0.13%) ⬆️
Go 83.04% <93.33%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/QueryInfo.h 100.00% <100.00%> (ø)
internal/core/src/index/Utils.h 88.88% <ø> (ø)
internal/core/src/index/VectorDiskIndex.cpp 76.96% <100.00%> (-1.05%) ⬇️
internal/core/src/index/VectorMemIndex.cpp 64.80% <100.00%> (-0.35%) ⬇️
internal/proxy/proxy.go 71.30% <100.00%> (+0.60%) ⬆️
internal/proxy/task.go 80.69% <ø> (ø)
internal/proxy/task_search.go 76.34% <100.00%> (+0.30%) ⬆️
internal/core/src/query/CachedSearchIterator.h 95.00% <95.00%> (ø)
internal/core/src/index/Utils.cpp 40.90% <88.23%> (+3.96%) ⬆️
internal/core/src/query/PlanProto.cpp 88.44% <75.00%> (-1.84%) ⬇️
... and 6 more

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
@PwzXxm PwzXxm force-pushed the search_iter_v2_s1_2.5 branch from 33672e6 to 4a7c34b Compare December 25, 2024 09:59
@mergify mergify bot removed the ci-passed label Dec 25, 2024
@PwzXxm PwzXxm force-pushed the search_iter_v2_s1_2.5 branch from 4a7c34b to 72b11b0 Compare December 25, 2024 10:14
Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit 3044496)
@PwzXxm PwzXxm force-pushed the search_iter_v2_s1_2.5 branch from 72b11b0 to ee57cee Compare December 25, 2024 11:29
@mergify mergify bot added the ci-passed label Dec 25, 2024
@MrPresent-Han
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ef40022 into milvus-io:2.5 Dec 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants