Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Determine the number of buffers based on the resource limits of the DataNode #38210

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #28410

master pr: #38209

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 4, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 55 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (a516475) to head (5e1a561).
Report is 6 commits behind head on 2.4.

Files with missing lines Patch % Lines
...ternal/datanode/compaction/clustering_compactor.go 30.37% 55 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38210      +/-   ##
==========================================
- Coverage   80.40%   72.15%   -8.26%     
==========================================
  Files        1074     1074              
  Lines      168650   168698      +48     
==========================================
- Hits       135609   121719   -13890     
- Misses      28589    42544   +13955     
+ Partials     4452     4435      -17     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.36% <100.00%> (ø)
...ternal/datanode/compaction/clustering_compactor.go 64.78% <30.37%> (-1.79%) ⬇️

... and 237 files with indirect coverage changes

@xiaocai2333 xiaocai2333 changed the title Determine the number of buffers based on the resource limits of the DataNode enhance: [2.4]Determine the number of buffers based on the resource limits of the DataNode Dec 4, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Dec 4, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.18 milestone Dec 5, 2024
@xiaocai2333 xiaocai2333 force-pushed the determine_buffers_num branch from d0f3138 to 5e1a561 Compare December 6, 2024 07:01
@mergify mergify bot added the ci-passed label Dec 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ddc40a7 into milvus-io:2.4 Dec 8, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants