Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set search params when using knowhere iterator #34731

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #34730

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 16, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jul 16, 2024
Copy link
Contributor

mergify bot commented Jul 16, 2024

@zhengbuqian

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan
Copy link
Collaborator

@zhengbuqian
can you take care of the go ut issue as well

@zhengbuqian zhengbuqian changed the title correctly set search params when using knowhere iterator fix: correctly set search params when using knowhere iterator Jul 17, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jul 17, 2024
@buqian-zilliz buqian-zilliz force-pushed the fix-groupby-metric-type branch from 64b35da to f7ae730 Compare July 17, 2024 03:46
@sre-ci-robot sre-ci-robot removed the lgtm label Jul 17, 2024
@mergify mergify bot added the ci-passed label Jul 17, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit aa5418a into milvus-io:master Jul 17, 2024
9 of 10 checks passed
@zhengbuqian zhengbuqian deleted the fix-groupby-metric-type branch July 17, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants