Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] update check for sparse hnsw index #33714

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #29419
pr: #33713

@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 June 7, 2024 06:27
@zhengbuqian zhengbuqian changed the title fix: update check for sparse hnsw index fix: [2.4] update check for sparse hnsw index Jun 7, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 7, 2024
@buqian-zilliz buqian-zilliz force-pushed the sparse-milvus-check-2.4 branch from abe79ee to 6caff33 Compare June 7, 2024 06:39
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jun 7, 2024
@buqian-zilliz buqian-zilliz force-pushed the sparse-milvus-check-2.4 branch 2 times, most recently from d575486 to 5a4a927 Compare June 7, 2024 07:27
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foxspy, zhengbuqian
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jun 7, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor

foxspy commented Jun 7, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jun 7, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@foxspy foxspy force-pushed the sparse-milvus-check-2.4 branch from 5a4a927 to d6d1480 Compare June 7, 2024 08:57
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 7, 2024
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Copy link
Contributor

mergify bot commented Jun 7, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (26db471) to head (d6d1480).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33714      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.01%     
==========================================
  Files        1010     1010              
  Lines      128613   128635      +22     
==========================================
+ Hits       105629   105669      +40     
+ Misses      19015    18995      -20     
- Partials     3969     3971       +2     
Files Coverage Δ
internal/proxy/task_index.go 80.92% <100.00%> (+0.16%) ⬆️
pkg/common/common.go 73.33% <ø> (ø)
pkg/util/indexparamcheck/base_checker.go 95.45% <100.00%> (+4.54%) ⬆️

... and 31 files with indirect coverage changes

@czs007 czs007 merged commit 39e341e into milvus-io:2.4 Jun 7, 2024
13 of 15 checks passed
@zhengbuqian zhengbuqian deleted the sparse-milvus-check-2.4 branch June 11, 2024 09:48
buqian-zilliz pushed a commit to zhengbuqian/milvus that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants