-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cherry-pick]Using zero serverID for metrics #31519
Conversation
@XuanYang-cn E2e jenkins job failed, comment |
Fixes: milvus-io#31516 pr: milvus-io#31518 Signed-off-by: yangxuan <[email protected]>
32d9b2c
to
f82f0af
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31519 +/- ##
==========================================
- Coverage 80.89% 80.80% -0.10%
==========================================
Files 980 965 -15
Lines 143575 136545 -7030
==========================================
- Hits 116150 110331 -5819
+ Misses 23540 22503 -1037
+ Partials 3885 3711 -174
|
related to #31597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #31516
pr: #31518