Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: update milvus-proto dep to latest version #30887

Closed
wants to merge 1 commit into from
Closed

enhance: update milvus-proto dep to latest version #30887

wants to merge 1 commit into from

Conversation

zhengbuqian
Copy link
Collaborator

mainly for #29419

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/XS Denotes a PR that changes 0-9 lines. labels Feb 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

latest proto won't build on its own, milvus code must be updated accordingly.

use #30889 instead.

@zhengbuqian zhengbuqian deleted the bump-proto-version branch February 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@czs007 czs007 Awaiting requested review from czs007

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhengbuqian @sre-ci-robot