Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rename SearchV2 to HybridSearch #29592

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Dec 29, 2023

related: milvus-io/milvus-proto#233
issue: #29593
/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement Issues or changes related to enhancement label Dec 29, 2023
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/dependency Pull requests that update a dependency file labels Dec 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Dec 29, 2023
Copy link
Contributor

mergify bot commented Dec 29, 2023

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Dec 29, 2023

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 29, 2023
@wayblink wayblink changed the title Rename SearchV2 to HybridSearch enhance: Rename SearchV2 to HybridSearch Dec 29, 2023
Copy link
Contributor

mergify bot commented Dec 29, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor

xige-16 commented Dec 29, 2023

/lgtm

Copy link
Contributor

mergify bot commented Dec 29, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 29, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 31, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Dec 31, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 31, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 1, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@wayblink
Copy link
Contributor Author

wayblink commented Jan 2, 2024

rerun ut

Copy link
Contributor

mergify bot commented Jan 2, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jan 2, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 3, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 3, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@wayblink
Copy link
Contributor Author

wayblink commented Jan 3, 2024

rerun ut

1 similar comment
@wayblink
Copy link
Contributor Author

wayblink commented Jan 4, 2024

rerun ut

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99e0f1e) 83.72% compared to head (fcdcbba) 80.83%.
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29592      +/-   ##
==========================================
- Coverage   83.72%   80.83%   -2.90%     
==========================================
  Files         679      921     +242     
  Lines      108623   127281   +18658     
==========================================
+ Hits        90949   102882   +11933     
- Misses      14361    21091    +6730     
+ Partials     3313     3308       -5     
Files Coverage Δ
internal/proxy/impl.go 85.74% <0.00%> (ø)
internal/distributed/proxy/service.go 81.61% <0.00%> (ø)

... and 251 files with indirect coverage changes

@xige-16
Copy link
Contributor

xige-16 commented Jan 4, 2024

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Jan 4, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 05d735c into milvus-io:master Jan 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants