Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Clustering optimization part 1 #28769

Closed
wants to merge 1 commit into from
Closed

feat: Clustering optimization part 1 #28769

wants to merge 1 commit into from

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Nov 27, 2023 •
edited
Loading

#28410

Define the proto of clustering and support bulkinsert with clustering info

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Nov 27, 2023
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 27, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2023

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (62fdfe1) 80.80% compared to head (bf3d133) 80.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28769      +/-   ##
==========================================
- Coverage   80.80%   80.78%   -0.02%     
==========================================
  Files         913      913              
  Lines      126747   126776      +29     
==========================================
+ Hits       102416   102420       +4     
- Misses      20999    21020      +21     
- Partials     3332     3336       +4
Files Coverage Δ
internal/datacoord/services.go 84.85% <100.00%> (+0.03%) ⬆️
internal/datanode/services.go 80.07% <100.00%> (+0.02%) ⬆️
internal/datacoord/meta.go 87.93% <75.00%> (-0.53%) ⬇️
internal/rootcoord/import_manager.go 77.33% <80.95%> (-0.22%) ⬇️

... and 16 files with indirect coverage changes

@wayblink wayblink mentioned this pull request Nov 30, 2023
Open
19 tasks
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Dec 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 8, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 8, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot removed the ci-passed label Dec 18, 2023
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Dec 18, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 18, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 18, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@wayblink wayblink force-pushed the cluster-dev-1 branch 3 times, most recently from f084338 to 064eb38 Compare December 21, 2023 12:53
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@wayblink wayblink closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@congqixia congqixia Awaiting requested review from congqixia

@jiaoew1991 jiaoew1991 Awaiting requested review from jiaoew1991

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file area/internal-api area/test dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayblink @sre-ci-robot @xiaofan-luan