Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Data race at tests/integration/target TestTarget #40258

Open
1 task done
bigsheeper opened this issue Feb 28, 2025 · 1 comment
Open
1 task done

[Bug]: Data race at tests/integration/target TestTarget #40258

bigsheeper opened this issue Feb 28, 2025 · 1 comment
Assignees
Labels
kind/bug Issues or changes related a bug test/integration integration test triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@bigsheeper
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Image
https://productionresultssa0.blob.core.windows.net/actions-results/617d9b8a-a122-46f6-b297-e4f81eeebf85/workflow-job-run-a15168b4-2827-5d1a-d23e-1601e9ea4678/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-02-28T06%3A21%3A56Z&sig=VPNOe84D7OOGJDIbWLN5BfVMpBNbitgaHE%2BarumUpbI%3D&ske=2025-02-28T14%3A42%3A41Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-02-28T02%3A42%3A41Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-02-28T06%3A11%3A51Z&sv=2025-01-05

Expected Behavior

No response

Steps To Reproduce

Milvus Log

No response

Anything else?

No response

@bigsheeper bigsheeper added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2025
Copy link

dosubot bot commented Feb 28, 2025

I found a similar closed issue titled "[Bug]: root_coord proxy_client_manager datarace in integration test" [1]. However, no solution was found in the comments of that issue.

For handling data races, Milvus typically uses synchronization mechanisms like sync.RWMutex to manage concurrent access to shared resources. For example, in the task_scheduler.go file, sync.RWMutex is used to protect access to shared maps, ensuring thread-safe operations [2][3]. Additionally, the github.com/sasha-s/go-deadlock library is used for detecting and handling data races [4].

In the specific case of the TestTarget, functions like SetSession and GetSession in internal/datanode/data_node.go use a mutex to prevent data races when accessing shared variables [5]. You might want to check if similar synchronization is needed in the code involved in the reported data race.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot dosubot bot added the test/integration integration test label Feb 28, 2025
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2025
@yanliang567 yanliang567 removed their assignment Feb 28, 2025
sre-ci-robot pushed a commit that referenced this issue Mar 2, 2025
sre-ci-robot pushed a commit that referenced this issue Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug test/integration integration test triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants