enhance: clean shard location cache after collection released (#40088)

issue: #40077 Signed-off-by: Wei Liu <[email protected]>
milvus-io · Feb 27, 2025 · 94f55df · 94f55df
1 parent fc31308
commit 94f55df
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/internal/querycoordv2/job/job_release.go b/internal/querycoordv2/job/job_release.go
@@ -103,6 +103,11 @@ func (job *ReleaseCollectionJob) Execute() error {
 		},
 		proxyutil.SetMsgType(commonpb.MsgType_ReleaseCollection))
 
+	// try best clean shard leader cache
+	job.proxyManager.InvalidateShardLeaderCache(job.ctx, &proxypb.InvalidateShardLeaderCacheRequest{
+		CollectionIDs: []int64{req.GetCollectionID()},
+	})
+
 	waitCollectionReleased(job.dist, job.checkerController, req.GetCollectionID())
 	metrics.QueryCoordReleaseCount.WithLabelValues(metrics.TotalLabel).Inc()
 	metrics.QueryCoordReleaseCount.WithLabelValues(metrics.SuccessLabel).Inc()
@@ -190,6 +195,10 @@ func (job *ReleasePartitionJob) Execute() error {
 				CollectionID: req.GetCollectionID(),
 			},
 			proxyutil.SetMsgType(commonpb.MsgType_ReleaseCollection))
+		// try best clean shard leader cache
+		job.proxyManager.InvalidateShardLeaderCache(job.ctx, &proxypb.InvalidateShardLeaderCacheRequest{
+			CollectionIDs: []int64{req.GetCollectionID()},
+		})
 
 		waitCollectionReleased(job.dist, job.checkerController, req.GetCollectionID())
 	} else {

diff --git a/internal/querycoordv2/job/job_test.go b/internal/querycoordv2/job/job_test.go
@@ -145,6 +145,7 @@ func (suite *JobSuite) SetupSuite() {
 
 	suite.proxyManager = proxyutil.NewMockProxyClientManager(suite.T())
 	suite.proxyManager.EXPECT().InvalidateCollectionMetaCache(mock.Anything, mock.Anything, mock.Anything).Return(nil).Maybe()
+	suite.proxyManager.EXPECT().InvalidateShardLeaderCache(mock.Anything, mock.Anything).Return(nil).Maybe()
 }
 
 func (suite *JobSuite) SetupTest() {

diff --git a/internal/querycoordv2/services_test.go b/internal/querycoordv2/services_test.go
@@ -131,6 +131,7 @@ func (suite *ServiceSuite) SetupSuite() {
 
 	suite.proxyManager = proxyutil.NewMockProxyClientManager(suite.T())
 	suite.proxyManager.EXPECT().InvalidateCollectionMetaCache(mock.Anything, mock.Anything, mock.Anything).Return(nil).Maybe()
+	suite.proxyManager.EXPECT().InvalidateShardLeaderCache(mock.Anything, mock.Anything).Return(nil).Maybe()
 }
 
 func (suite *ServiceSuite) SetupTest() {