Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-id check for upsert for V2 #1213

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Remove auto-id check for upsert for V2 #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/io/milvus/v2/utils/DataUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ private void checkAndSetRowData(DescribeCollectionResp descColl, List<JsonObject
rowFieldData = JsonNull.INSTANCE;
}

if (field.getAutoID() == Boolean.TRUE) {
// from v2.4.10, milvus allows upsert for auto-id pk, no need to check for upsert action
if (field.getAutoID() == Boolean.TRUE && insertBuilder != null) {
String msg = String.format("The primary key: %s is auto generated, no need to input.", fieldName);
throw new MilvusClientException(ErrorCode.INVALID_PARAMS, msg);
}
Expand Down
Loading