Update describeAlias to use request (#754)

Signed-off-by: Nian Liu <[email protected]>
milvus-io · Feb 5, 2024 · ea92b22 · ea92b22
1 parent 20dc2b9
commit ea92b22
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 10 deletions.
diff --git a/src/main/java/io/milvus/v2/client/MilvusClientV2.java b/src/main/java/io/milvus/v2/client/MilvusClientV2.java
@@ -22,6 +22,7 @@
 import io.milvus.v2.service.utility.UtilityService;
 import io.milvus.v2.service.utility.request.AlterAliasReq;
 import io.milvus.v2.service.utility.request.CreateAliasReq;
+import io.milvus.v2.service.utility.request.DescribeAliasReq;
 import io.milvus.v2.service.utility.request.DropAliasReq;
 import io.milvus.v2.service.utility.response.DescribeAliasResp;
 import io.milvus.v2.service.utility.response.ListAliasResp;
@@ -487,8 +488,8 @@ public ListAliasResp listAliases() {
      *
      * @return DescribeAliasResp
      */
-    public DescribeAliasResp describeAlias(String alias) {
-        return utilityService.describeAlias(this.blockingStub, alias);
+    public DescribeAliasResp describeAlias(DescribeAliasReq request) {
+        return utilityService.describeAlias(this.blockingStub, request);
     }
 
     /**

diff --git a/src/main/java/io/milvus/v2/service/utility/UtilityService.java b/src/main/java/io/milvus/v2/service/utility/UtilityService.java
@@ -5,10 +5,7 @@
 import io.milvus.param.R;
 import io.milvus.param.RpcStatus;
 import io.milvus.v2.service.BaseService;
-import io.milvus.v2.service.utility.request.AlterAliasReq;
-import io.milvus.v2.service.utility.request.CreateAliasReq;
-import io.milvus.v2.service.utility.request.DropAliasReq;
-import io.milvus.v2.service.utility.request.FlushReq;
+import io.milvus.v2.service.utility.request.*;
 import io.milvus.v2.service.utility.response.DescribeAliasResp;
 import io.milvus.v2.service.utility.response.ListAliasResp;
 
@@ -52,10 +49,10 @@ public void alterAlias(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub,
         rpcUtils.handleResponse(title, status);
     }
 
-    public DescribeAliasResp describeAlias(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, String alias) {
-        String title = String.format("Describe alias %s", alias);
+    public DescribeAliasResp describeAlias(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, DescribeAliasReq request) {
+        String title = String.format("Describe alias %s", request.getAlias());
         io.milvus.grpc.DescribeAliasRequest describeAliasRequest = io.milvus.grpc.DescribeAliasRequest.newBuilder()
-                .setAlias(alias)
+                .setAlias(request.getAlias())
                 .build();
         io.milvus.grpc.DescribeAliasResponse response = blockingStub.describeAlias(describeAliasRequest);
 

diff --git a/src/main/java/io/milvus/v2/service/utility/request/DescribeAliasReq.java b/src/main/java/io/milvus/v2/service/utility/request/DescribeAliasReq.java
@@ -0,0 +1,10 @@
+package io.milvus.v2.service.utility.request;
+
+import lombok.Data;
+import lombok.experimental.SuperBuilder;
+
+@Data
+@SuperBuilder
+public class DescribeAliasReq {
+    private String alias;
+}
diff --git a/src/test/java/io/milvus/v2/service/utility/UtilityTest.java b/src/test/java/io/milvus/v2/service/utility/UtilityTest.java
@@ -3,6 +3,7 @@
 import io.milvus.v2.BaseTest;
 import io.milvus.v2.service.utility.request.AlterAliasReq;
 import io.milvus.v2.service.utility.request.CreateAliasReq;
+import io.milvus.v2.service.utility.request.DescribeAliasReq;
 import io.milvus.v2.service.utility.request.DropAliasReq;
 import io.milvus.v2.service.utility.response.DescribeAliasResp;
 import io.milvus.v2.service.utility.response.ListAliasResp;
@@ -40,7 +41,10 @@ void testAlterAlias() {
 
     @Test
     void describeAlias() {
-        DescribeAliasResp statusR = client_v2.describeAlias("test_alias");
+        DescribeAliasReq req = DescribeAliasReq.builder()
+                .alias("test_alias")
+                .build();
+        DescribeAliasResp statusR = client_v2.describeAlias(req);
     }
     @Test
     void listAliases() {