Fix a retry bug (#829)

Signed-off-by: yhmo <[email protected]>
milvus-io · Mar 29, 2024 · 9439a12 · 9439a12
1 parent 415e8b8
commit 9439a12
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/src/main/java/io/milvus/client/MilvusServiceClient.java b/src/main/java/io/milvus/client/MilvusServiceClient.java
@@ -328,14 +328,18 @@ private <T> R<T> retry(Callable<R<T>> callable) {
                     return resp;
                 }
 
-                // print log, follow the pymilvus logic
-                if (k > 3) {
-                    logWarning(String.format("Retry(%d) with interval %dms. Reason: %s",
-                            k, retryIntervalMs, e.getMessage()));
-                }
-
-                // sleep for interval
-                if (k != maxRetryTimes) {
+                if (k >= maxRetryTimes) {
+                    // finish retry loop, return the response of the last retry
+                    String msg = String.format("Finish %d retry times, stop retry", maxRetryTimes);
+                    logError(msg);
+                    return resp;
+                } else {
+                    // sleep for interval
+                    // print log, follow the pymilvus logic
+                    if (k > 3) {
+                        logWarning(String.format("Retry(%d) with interval %dms. Reason: %s",
+                                k, retryIntervalMs, e.getMessage()));
+                    }
                     TimeUnit.MILLISECONDS.sleep(retryIntervalMs);
                 }