deleteIds Marked as deprecated

milvus-io · Oct 23, 2023 · 57dbcb4 · 57dbcb4
1 parent d1866d9
commit 57dbcb4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/src/main/java/io/milvus/client/AbstractMilvusGrpcClient.java b/src/main/java/io/milvus/client/AbstractMilvusGrpcClient.java
@@ -2972,9 +2972,8 @@ public R<DeleteResponse> delete(DeleteIdsParam requestParam) {
                     .withCollectionName(requestParam.getCollectionName())
                     .withExpr(expr)
                     .build();
-            R<MutationResult> resultR = delete(deleteParam);
-            MutationResultWrapper resultWrapper = new MutationResultWrapper(resultR.getData());
-            return R.success(DeleteResponse.builder().deleteIds(resultWrapper.getInsertIDs()).build());
+            delete(deleteParam);
+            return R.success(DeleteResponse.builder().deleteIds(Lists.newArrayList()).build());
         } catch (StatusRuntimeException e) {
             logError("Delete RPC failed! Collection name:{}",
                     requestParam.getCollectionName(), e);

diff --git a/src/main/java/io/milvus/param/highlevel/dml/response/DeleteResponse.java b/src/main/java/io/milvus/param/highlevel/dml/response/DeleteResponse.java
@@ -32,5 +32,10 @@
 @Getter
 @ToString
 public class DeleteResponse {
+    /**
+     * In the new version, this method only returns an empty list and does not return specific values
+     * Mark is as deprecated, keep it to compatible with the legacy code
+     */
+    @Deprecated
     public List<?> deleteIds;
 }
diff --git a/src/test/java/io/milvus/client/MilvusClientDockerTest.java b/src/test/java/io/milvus/client/MilvusClientDockerTest.java
@@ -2107,6 +2107,5 @@ private static void testHighLevelDelete(String collectionName, List primaryIds)
         String outPutStr = String.format("collectionName:%s, primaryIds:%s, deleteResponseR:%s", collectionName, primaryIds, deleteResponseR);
         System.out.println(outPutStr);
         Assertions.assertEquals(R.Status.Success.getCode(), deleteResponseR.getStatus().intValue());
-        Assertions.assertEquals(primaryIds.size(), deleteResponseR.getData().getDeleteIds().size());
     }
 }
diff --git a/tests/milvustest/src/test/java/com/zilliz/milvustest/serverless/HighLevelTest.java b/tests/milvustest/src/test/java/com/zilliz/milvustest/serverless/HighLevelTest.java
@@ -137,7 +137,6 @@ public void delete() {
                 .withPrimaryIds(integers)
                 .build());
         Assert.assertEquals(delete.getStatus().intValue(), R.Status.Success.getCode());
-        Assert.assertEquals(delete.getData().getDeleteIds().size(), integers.size());
     }
 
     @Severity(SeverityLevel.BLOCKER)
@@ -240,7 +239,6 @@ public void deleteVarcharPKData() {
                 .withPrimaryIds(pks)
                 .build());
         Assert.assertEquals(delete.getStatus().intValue(), R.Status.Success.getCode());
-        Assert.assertEquals(delete.getData().getDeleteIds().size(), pks.size());
     }