Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enabling mmap for collection #632

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 5, 2023

  • Add entity.Mmap(enabled bool) for enabling mmap

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #632 (3cb6a8e) into master (d1df1d6) will decrease coverage by 0.15%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   74.95%   74.81%   -0.15%     
==========================================
  Files          44       44              
  Lines        4125     4133       +8     
==========================================
  Hits         3092     3092              
- Misses        921      929       +8     
  Partials      112      112              
Files Coverage Δ
entity/collection_attr.go 70.37% <0.00%> (-29.63%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Dec 5, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Dec 5, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 83f95d7 into milvus-io:master Dec 5, 2023
6 checks passed
@yah01
Copy link
Member Author

yah01 commented Dec 5, 2023

example:

cli.AlterCollection(ctx, collectionName, entity.Mmap(true))

yah01 added a commit to yah01/milvus-sdk-go that referenced this pull request Dec 6, 2023
yah01 added a commit to yah01/milvus-sdk-go that referenced this pull request Dec 7, 2023
sre-ci-robot pushed a commit that referenced this pull request Dec 7, 2023
yah01 added a commit to yah01/milvus-sdk-go that referenced this pull request Jan 30, 2024
yah01 added a commit to yah01/milvus-sdk-go that referenced this pull request Jan 30, 2024
sre-ci-robot pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants