Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support row based Array & fix varchar array type #621

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

congqixia
Copy link
Contributor

See also #609
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Nov 8, 2023
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 November 8, 2023 18:11
@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #621 (763dfac) into master (40a4e1e) will decrease coverage by 0.56%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   75.15%   74.60%   -0.56%     
==========================================
  Files          41       42       +1     
  Lines        4033     4063      +30     
==========================================
  Hits         3031     3031              
- Misses        890      920      +30     
  Partials      112      112              
Files Coverage Δ
entity/columns_array_gen.go 0.00% <ø> (ø)
entity/schema.go 91.25% <100.00%> (ø)
entity/columns.go 50.38% <0.00%> (-1.20%) ⬇️
entity/rows.go 77.11% <0.00%> (-7.12%) ⬇️
entity/columns_array.go 0.00% <0.00%> (ø)

Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 8, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed auto merge needed label label Nov 8, 2023
@sre-ci-robot sre-ci-robot merged commit 415f277 into milvus-io:master Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants