no need for move-iterator in DynamicConverter

Summary: There are some odd interactions with `boost::iterator_adaptor`. Differential Revision: D34729880 fbshipit-source-id: 9a791410df0e2c3a9b61b0a94556346c9210664c
milvus-io · Mar 9, 2022 · ca8bb53 · ca8bb53
1 parent aace9fe
commit ca8bb53
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/folly/DynamicConverter.h b/folly/DynamicConverter.h
@@ -159,12 +159,14 @@ class Transformer
 
  public:
   explicit Transformer(const It& it) : Transformer::iterator_adaptor_(it) {}
+
+  ttype&& operator*() const { return std::move(dereference()); }
 };
 
 // conversion factory
 template <typename T, typename It>
-inline std::move_iterator<Transformer<T, It>> conversionIterator(const It& it) {
-  return std::make_move_iterator(Transformer<T, It>(it));
+inline Transformer<T, It> conversionIterator(const It& it) {
+  return Transformer<T, It>(it);
 }
 
 } // namespace dynamicconverter_detail