enhance: Sync v1.0.x pr to main branch (part4) #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Congqi Xia <[email protected]>
This PR set etcd address to default 2379 port if user param does not contain port. Signed-off-by: Congqi Xia <[email protected]>
fix: milvus-io#329 Signed-off-by: bigsheeper <[email protected]>
Add `scan-deltalog` command to scan deltalogs and locate specified existence --------- Signed-off-by: Congqi Xia <[email protected]>
The basePath & metaPath shall be separated since most of meta info are stored under metaPath but some other info (say config-etcd) are stored under basePath Signed-off-by: Congqi Xia <[email protected]>
Add balance-segment command to manual load balance segments Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Wei Liu <[email protected]> Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Previously, scan-binlog command need to manually provide outputFields for pk column even the pk column & ts column is always fetched. This PR unifies `scan-binlog` & `scan-deltalog` command to have the default `$pk` & `$timestamp` env value for filter expression. Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: bigsheeper <[email protected]> Signed-off-by: Congqi Xia <[email protected]>
Previously common.ListSegmentIndex has default timeout of 3 seconds, which could cause command fail when segment index number is large Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Signed-off-by: Congqi Xia <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #332 #334 #335 #336 #337 #338 #339 #340 #343 #344 #346