support storage analysis with statistics (#215) #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congqixia
reviewed
Nov 20, 2023
states/segment_anaylsis.go
Outdated
Comment on lines
70
to
72
| totalBinlogCount += len(segment.GetBinlogs()) | ||
| totalDeltaLogCount += len(segment.GetDeltalogs()) | ||
| totalStatsLogCount += len(segment.GetStatslogs()) |
There was a problem hiding this comment.
this is the number of FieldBinlog not actually the Binlog number
states/segment_anaylsis.go
Outdated
There was a problem hiding this comment.
It's recommended to modify show segment command to list binlog/statslog/deltalog file number
Signed-off-by: MrPresent-Han <[email protected]>
MrPresent-Han
force-pushed
the
support-statistic-files
branch
from
753c045 to
43dbf7b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #215