Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp constructors #57

Open
mikemc opened this issue Oct 16, 2020 · 0 comments
Open

Revamp constructors #57

mikemc opened this issue Oct 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mikemc
Copy link
Owner

mikemc commented Oct 16, 2020

There are a couple of issues with the phyloseq constructions for otu table, sample data, and tax tables. One has to do with how dummy sample and otu names are created, when the existing names are 1:n; see #53. Another example is that the data.frame tax_table method uses dummy names instead of row names for the taxa names. Given the stalled development of phyloseq, it might be worth completely reimplementing the constructors in speedyseq to have a more flexible and consistent behavior.

  • The "sa#" and "ta#" dummy names will not be created unless the relevant (row/col)names is NULL, at least by default. So this would only happen for matrices, not data frames, since the names are never null for data frames. Perhaps have an optional arg that can give the original phyloseq behavior (though I think just giving a warning would be sufficient)
  • Have methods that work as expected for data.frame, tibble, and data.table, and perhaps also for Data.Frame, Biom (from the biomformat package), and matrix types from Matrix
@mikemc mikemc added the enhancement New feature or request label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant