Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to subset_*() commands #54

Open
mikemc opened this issue Sep 12, 2020 · 0 comments
Open

Add checks to subset_*() commands #54

mikemc opened this issue Sep 12, 2020 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@mikemc
Copy link
Owner

mikemc commented Sep 12, 2020

Currently, no warning is given for typos such as subset_taxa(ps, phylum = "Bacteroidetes"). Instead, this command will simply run and not filter out anything. Contrast with dplyr::filter(), which gives a helpful error message suggesting to use == instead of =.

Adding such behavior seems unambiguously beneficial, but there is perhaps some value in the simplicity of keeping the subset_ commands as simple wrappers around base::subset().

@mikemc mikemc added enhancement New feature or request question Further information is requested labels Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant