Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better handling of name conflicts in internal methods #51

Open
mikemc opened this issue Sep 9, 2020 · 2 comments
Open

Add better handling of name conflicts in internal methods #51

mikemc opened this issue Sep 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@mikemc
Copy link
Owner

mikemc commented Sep 9, 2020

For example, currently the taxonomyTable method for merge_taxa_vec() assumes that there are no taxonomic ranks named "group" or "taxon"
@mikemc mikemc added the bug Something isn't working label Sep 9, 2020
@mikemc
Copy link
Owner Author

mikemc commented Sep 12, 2020 •
edited
Loading

As a quick fix, could perhaps use ...group and ...taxon to make conflicts very unlikely, and exit with an error if these would cause a conflict.

mikemc added a commit that referenced this issue Sep 12, 2020
@mikemc
Change internal var names to avoid conflicts
57dd0b2 
See Issue #51.
@mikemc
Copy link
Owner Author

mikemc commented Jun 23, 2021

Instead of ...taxon, might instead use .otu since this is the special column name being used by new ps_tibble() and dplyr verb functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikemc