Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when an operation results in 0 samples or taxa #39

Open
mikemc opened this issue Jul 6, 2020 · 0 comments
Open

Improve error messages when an operation results in 0 samples or taxa #39

mikemc opened this issue Jul 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mikemc
Copy link
Owner

mikemc commented Jul 6, 2020

Currently if one performs a subset_samples operation that removes all samples, they get an error message

Error in validObject(.Object) :
  invalid class “sample_data” object: Sample Data must have non-zero dimensions.

Instead, we should detect that 0 samples pass the subsetting operation and inform the user in an error message, to help spot the problem. Similarly for subsetting taxa with subset_taxa.
@mikemc mikemc added the enhancement New feature or request label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikemc