Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give messages when samples or taxa are dropped #36

Open
mikemc opened this issue Jul 3, 2020 · 1 comment
Open

Give messages when samples or taxa are dropped #36

mikemc opened this issue Jul 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@mikemc
Copy link
Owner

mikemc commented Jul 3, 2020

Examples of cases where it seems worth it to message() the user when samples or taxa are dropped include

  • Overwriting sample data with sample_data(ps) <- can silently drop samples
  • Similar for tax_table(), otu_table(), etc
  • tax_glom() with default params will drop taxa with bad_empty value at that rank
@mikemc mikemc added the enhancement New feature or request label Jul 3, 2020
@mikemc
Copy link
Owner Author

mikemc commented Oct 2, 2020

Another case is when phyloseq() is called - currently at error is given only if no samples or taxa match. However, to improve this and some of the cases above would require rewriting core parts of phyloseq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant