Defer accessing fetchResults settings #315
Open
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Setting custom fetchResults prior to obtaining Photos permission from the user results in null AssetCollections, and thus will present an empty ImagePickerController the first time it is presented.
For instance
will have the effect of presenting an empty picker the first time after permissions are first granted.
Proposed solution
Defer the access of the fetchResults settings by using a function rather than a var.
Note
There are other ways of solving this, such as adding an
onAuthorization
closure to thepresentImagePicker
call and allowing settings to be passed in there.