Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimizations #287

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Performance optimizations #287

merged 1 commit into from
Sep 26, 2020
+22 −22

Conversation

mikaoj
Copy link
Owner

@mikaoj mikaoj commented Jul 17, 2020

  • Had forgot to set prefetch data source on collection view.
  • Removed image size calculation on every cell dequeue.
  • Use PHCachingImageManager caching API.
  • Clear image cache when changing image size or fetch result.
  • Use nil for fetch options as setting it might override some performance optimizations apple has done according to some old SO post.

@mikaoj
Performance optimizations
974c3fc 
- Had forgot to set prefetch data source on collection view.
- Removed image size calculation on every cell dequeue.
- Use PHCachingImageManager caching API.
- Clear image cache when changing image size or fetch result.
@mikaoj
Copy link
Owner Author

mikaoj commented Jul 17, 2020

#271

@mikaoj mikaoj merged commit b964825 into master Sep 26, 2020
@mikaoj mikaoj deleted the feature/performance_optimization branch September 26, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikaoj