Add Infinix system app to list of invalid browsers #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
reviewed
Jan 30, 2025
MajorTanya
force-pushed
the
fix-infinix-invalid-browser
branch
from
f6e8f97 to
2f83981
Compare
`com.transsion.resolver` being picked by the system as a suitable browser caused a Mihon user with an Infinix device to be unable to open any links in browsers, including tracker login and opening a WebView page in a real browser. Co-authored-by: AntsyLich <[email protected]>
MajorTanya
force-pushed
the
fix-infinix-invalid-browser
branch
from
2f83981 to
c223ebb
Compare
|
I call bs on that build failure. It's failing on MigratorTest.initialVersion for some reason |
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Feb 4, 2025
* Add Infinix system app to list of invalid browsers `com.transsion.resolver` being picked by the system as a suitable browser caused a Mihon user with an Infinix device to be unable to open any links in browsers, including tracker login and opening a WebView page in a real browser. Co-authored-by: AntsyLich <[email protected]> * Add docstring to DeviceUtil.invalidDefaultBrowsers --------- Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit bfc8320aa4720dc3b908aab1b8a1ffb99d43193b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.transsion.resolverbeing picked by the system as a suitable browser caused a Mihon user with an Infinix device to be unable to open any links in browsers, including tracker login and opening a WebView page in a real browser.Filtering this resolver via our list of invalid browsers enabled the system to suggest their Chrome browser instead, making the affected features work again as expected.