Added camera switch mode: Front/Back #97
Conversation
|
I'll handle it today |
|
|
||
|
|
||
| ### Camera mode | ||
| Switching camera for front or back. By default back set |
There was a problem hiding this comment.
I'm not very good with English 😓 , but maybe this sentence is clearer, wdyt?
Switching the front or back camera. By default the back one is set
And what about adding a reminder to put this lines in the manifest?:
<uses-permission android:name="android.permission.CAMERA"/>
<uses-feature android:name="android.hardware.camera" android:required="false" />
<uses-feature android:name="android.hardware.camera.front" android:required="false" />
| @@ -3,6 +3,8 @@ | |||
| package="com.miguelbcr.ui.rx_paparazzo2.sample"> | |||
|
|
|||
| <uses-permission android:name="android.permission.CAMERA"/> | |||
| <uses-feature android:name="android.hardware.camera" android:required="false" /> | |||
| <uses-feature android:name="android.hardware.camera.front" android:required="false" /> | |||
|
|
||
| BACK | ||
|
|
||
| } |
There was a problem hiding this comment.
[nit] Maybe without spaces?
public enum CameraMode {
FRONT,
BACK
}
| if (CameraMode.FRONT.equals(config.getCameraMode())) { | ||
| intent.putExtra("android.intent.extras.CAMERA_FACING", android.hardware.Camera.CameraInfo.CAMERA_FACING_FRONT); | ||
| intent.putExtra("android.intent.extras.LENS_FACING_FRONT", 1); | ||
| intent.putExtra("android.intent.extra.USE_FRONT_CAMERA", true); |
There was a problem hiding this comment.
It seems that android.hardware.Camera.CameraInfo is deprecated from API 21 (Build.VERSION_CODES.LOLLIPOP) -> https://developer.android.com/reference/android/hardware/Camera.CameraInfo
Instead, suggests to use android.hardware.camera2. -> https://developer.android.com/reference/android/hardware/camera2/package-summary
I can see that LENS_FACING_FRONT was added from API 21:
I wonder if you have tested it in several android versions just to make sure it works, for instance, API 18, 21, 22, 27
I'll try it too...
No description provided.