Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GraphNotificationClient subscription renewal process #3142

Open
wants to merge 24 commits into
base: next/mgt-chat
Choose a base branch
from
Open

Refactor GraphNotificationClient subscription renewal process #3142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
eb988ae
working refactor
andrewDoing Mar 13, 2024
0470770
progress
andrewDoing Mar 13, 2024
ef3ba50
fix renewal loop
TechnicallyWilliams Mar 13, 2024
c762b49
update cache cleanup in renewal loop
TechnicallyWilliams Mar 13, 2024
27cb646
update logging
TechnicallyWilliams Mar 13, 2024
57f662d
merge
andrewDoing Mar 13, 2024
ddeb35b
fix renewal count
andrewDoing Mar 13, 2024
c9e669a
Merge branch 'andoing/connection-refactor' of https://github.com/andr…
andrewDoing Mar 13, 2024
3c6659e
copy over logic for ignoring messages from other subscriptions
TechnicallyWilliams Mar 13, 2024
7d49ac1
generate groupid once
TechnicallyWilliams Mar 13, 2024
b963a36
fix a lot
andrewDoing Mar 14, 2024
0996d11
Merge branch 'andoing/connection-refactor' of https://github.com/andr…
andrewDoing Mar 14, 2024
685cb89
remove commented code
andrewDoing Mar 14, 2024
b7e420e
cache correct subscription
TechnicallyWilliams Mar 14, 2024
f559402
adding back notification client error emitter
TechnicallyWilliams Mar 14, 2024
c1a6dc7
restore shared expirationtime for renewals
TechnicallyWilliams Mar 14, 2024
b348cd5
synchronize current active chat with it's subscriptionIds
TechnicallyWilliams Mar 14, 2024
af8a9a7
move renewalcount; only set previousChatId if renewal was successfull
TechnicallyWilliams Mar 15, 2024
e143fa5
synchronize current active chat with it's subscriptionIds
TechnicallyWilliams Mar 15, 2024
bdc1963
update log msgs; rm methods from prev implem
TechnicallyWilliams Mar 15, 2024
0f604b0
add doc comments to public methods
andrewDoing Mar 15, 2024
c32c769
replace renewal accumulator with last renewal time
TechnicallyWilliams Mar 18, 2024
b45711b
Merge branch 'andoing/connection-refactor' of https://github.com/andr…
TechnicallyWilliams Mar 18, 2024
f38bf32
remove whitespace
TechnicallyWilliams Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading