-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix dynamic group story accessibility concerns #3139
Conversation
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
📖 The updated storybook is available here |
1 similar comment
📖 The updated storybook is available here |
@Raisul123 I've re-worked the story to try to address the linked a11y issues. Could you please validate these changes and if there are problems with the proposed fix give us feedback and guidance as to how we should address them. |
Hi @gavinbarron We have taken action on the #3125 #3126 #3127 And for the bug #3109, issue is still repro at our end. Please refer to the below snippet for the reference. |
📖 The updated storybook is available here |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mnickii and @gavinbarron, This issue is still repro on the updated URL as of now it is looks like a selected text and we have seen this behavior at Fluent side as well so could you please suggest us whether do we need to follow the external process and route this bug to Fluent team or not? |
Closes #3125 #3126 #3127
PR Type
Description of the changes
Reworks the dynamic groupid story for people picker to address a11y concerns
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information