Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pipelines to run on node 20 #2986

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2983

PR Type

  • Build or CI related changes

Description of the changes

Updates pipelines to use nodejs 20 for most jobs, CI runs on 18 and 20

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner January 29, 2024 21:49
Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
Copy link

🚀 New react-contoso sample application deployed here

@sebastienlevert
Copy link
Contributor

We're getting errors deploying the PR to storybook @gavinbarron

@gavinbarron
Copy link
Member Author

Oh, there's a rollup failure that we missed on that change, adding the fix here

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@sebastienlevert
Copy link
Contributor

Just realized that the home page of React Contoso is pretty... Hmmm... Crowded! I don't really mind as it's a test app but it looks weird (and breaks some of the theming as it uses the default theme from the browser and not the one from the set dropdown menu.). What should we do with this?

@gavinbarron
Copy link
Member Author

Just realized that the home page of React Contoso is pretty... Hmmm... Crowded! I don't really mind as it's a test app but it looks weird (and breaks some of the theming as it uses the default theme from the browser and not the one from the set dropdown menu.). What should we do with this?

let's clean that up, it should never have gotten that way in main, and that's largely my fault.

@gavinbarron gavinbarron merged commit 5e261c0 into main Jan 30, 2024
9 checks passed
@gavinbarron gavinbarron deleted the chore/node-version branch January 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[CHORE] Update the Node matrix
3 participants