-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pipelines to run on node 20 #2986
Conversation
🚀 New react-contoso sample application deployed here |
1 similar comment
🚀 New react-contoso sample application deployed here |
We're getting errors deploying the PR to storybook @gavinbarron |
…oft-graph-toolkit into chore/node-version
Oh, there's a rollup failure that we missed on that change, adding the fix here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
1 similar comment
📖 The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Just realized that the home page of React Contoso is pretty... Hmmm... Crowded! I don't really mind as it's a test app but it looks weird (and breaks some of the theming as it uses the default theme from the browser and not the one from the set dropdown menu.). What should we do with this? |
let's clean that up, it should never have gotten that way in main, and that's largely my fault. |
Closes #2983
PR Type
Description of the changes
Updates pipelines to use nodejs 20 for most jobs, CI runs on 18 and 20
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information