Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks Official Doc - "Platforms" Parameter update #9487

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bookmarks Official Doc - "Platforms" Parameter update #9487

wants to merge 3 commits into from

Conversation

Lin-Qi-MS
Copy link

Important

Required for API changes:

  • Link to API.md file: ADD LINK HERE
  • Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl): ADD LINK HERE

Add other supporting information, such as a description of the PR changes:

Currently the doc is out of date as it contains many parameters that no longer supported in Graph explorer API. Delete the unused parameters and keep it up to date.

Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d35ea9a:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/api/search-searchentity-post-bookmarks.md ✅Succeeded
api-reference/v1.0/api/search-searchentity-post-bookmarks.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Lin-Qi-MS
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@Danielabom
Copy link
Contributor

@Lin-Qi-MS, please add the "ready for content review" label if you're ready for us to continue with the review.

@Lin-Qi-MS
Copy link
Author

Lin-Qi-MS commented Dec 28, 2024 •
edited
Loading

@Danielabom I did not find any place to add the label, but this PR is ready to review now. Or could you share me a snapshot where the label is?

@Danielabom Danielabom self-assigned this Dec 31, 2024
Danielabom
Danielabom reviewed Dec 31, 2024
View reviewed changes
api-reference/beta/api/search-searchentity-post-bookmarks.md
@@ -57,7 +57,7 @@ The following table shows the properties that are available when you create a [b
|groupIds|String collection|The list of security groups that are able to view this bookmark.|
|keywords|[microsoft.graph.search.answerKeyword](../resources/search-answerKeyword.md)|Keywords that trigger this bookmark to appear in search results.|
|languageTags|String collection|A list of geographically specific language names in which this bookmark can be viewed. Each language tag value follows the pattern {language}-{region}. For example, `en-us` is English as used in the United States. For the list of possible values, see [Supported language tags](../resources/search-api-answers-overview.md#supported-language-tags).|
|platforms|microsoft.graph.devicePlatformType collection|List of devices and operating systems that are able to view this bookmark. Possible values are: `android`, `androidForWork`, `ios`, `macOS`, `windowsPhone81`, `windowsPhone81AndLater`, `windows10AndLater`, `androidWorkProfile`, `unknown`, `androidASOP`, `androidMobileApplicationManagement`, `iOSMobileApplicationManagement`, `unknownFutureValue`.|
|platforms|microsoft.graph.devicePlatformType collection|List of devices and operating systems that are able to view this bookmark. Possible values are: `android`, `windows`, `ios`, `macOs`, `unknown`.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lin-Qi-MS, quick question, these are the enum values I have in beta
{B3A33C26-32E9-4665-96F7-A9E59AF2221C}
Are we maybe missing values?

Danielabom
Danielabom reviewed Dec 31, 2024
View reviewed changes
api-reference/v1.0/api/search-searchentity-post-bookmarks.md
@@ -55,7 +55,7 @@ The following table shows the properties that are available when you create a [b
|groupIds|String collection|The list of security groups that are able to view this bookmark.|
|keywords|[microsoft.graph.search.answerKeyword](../resources/search-answerKeyword.md)|Keywords that trigger this bookmark to appear in search results.|
|languageTags|String collection|A list of geographically specific language names in which this bookmark can be viewed. Each language tag value follows the pattern {language}-{region}. For example, `en-us` is English as used in the United States. For the list of possible values, see [Supported language tags](../resources/search-api-answers-overview.md#supported-language-tags).|
|platforms|microsoft.graph.devicePlatformType collection|List of devices and operating systems that are able to view this bookmark. Possible values are: `android`, `androidForWork`, `ios`, `macOS`, `windowsPhone81`, `windowsPhone81AndLater`, `windows10AndLater`, `androidWorkProfile`, `unknown`, `androidASOP`, `androidMobileApplicationManagement`, `iOSMobileApplicationManagement`, `unknownFutureValue`.|
|platforms|microsoft.graph.devicePlatformType collection|List of devices and operating systems that are able to view this bookmark. Possible values are: `android`, `windows`, `ios`, `unknown`, `macOs`.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here
{AABD1049-1835-4EA1-9B38-0721C75E8C5F}

@Danielabom Danielabom added changes requested content review in progress do not merge Use this label to indicate to the repository admins that your PR Is not ready to merge into master. labels Jan 3, 2025
@Danielabom
Copy link
Contributor

@Lin-Qi-MS, friendly reminder to please review my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danielabom Danielabom Danielabom left review comments

Assignees

@Danielabom Danielabom

@Lin-Qi-MS Lin-Qi-MS

Labels
changes requested content review in progress do not merge Use this label to indicate to the repository admins that your PR Is not ready to merge into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lin-Qi-MS @Danielabom