Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature search UX, add dark mode, and update deps #3422

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Jan 7, 2025

Changes:

  • Added dark mode with a theme switcher
  • Better sorting: match position + suffix length
  • Search terms now added to URL for easy sharing
  • Branch switching auto-updates search results
  • Improved search result view on mobile
  • Updated Node.js dependency

@riverar riverar changed the title Improve search UX, add dark mode, and update dependencies Improve feature search UX, add dark mode, and update deps Jan 7, 2025
@kennykerr kennykerr requested a review from Copilot January 7, 2025 13:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • web/features/tsconfig.json: Language not supported
Comments suppressed due to low confidence (4)

web/features/src/app.tsx:167

  • The initialization of the query state with params.query! ?? '' might cause an error if params.query is undefined. It should be initialized with params.query ?? '' instead.
const [query, setQuery] = useState(params.query! ?? '');

web/features/src/worker/search.ts:100

  • [nitpick] The variable name 'query_lower' is ambiguous. It should be renamed to 'queryLower' for better readability.
const query_lower = query.toLowerCase();

web/features/src/worker/search.ts:101

  • [nitpick] The variable name 'a_lower' is ambiguous. It should be renamed to 'nameALower' for better readability.
const a_lower = a.name.toLowerCase();

web/features/src/worker/search.ts:102

  • [nitpick] The variable name 'b_lower' is ambiguous. It should be renamed to 'nameBLower' for better readability.
const b_lower = b.name.toLowerCase();
@riverar riverar merged commit 9911fee into master Jan 7, 2025
76 checks passed
@riverar riverar deleted the rafael/improve-search-ux branch January 7, 2025 14:57
@riverar
Copy link
Collaborator Author

riverar commented Jan 7, 2025

@tim-weis Heads up Tim, added a few of the items you requested! (e.g., better result sort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants