chat: prototype of choices API for response stream #238011
Open
+338
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API similar to buttons in notifications and is a bit more flexible than the current confirmation API. It could supplant confirmation, but I left confirmation as-is for the moment. Marking this PR initially as a draft pending some discussion about awaitable choices
jrieken
reviewed
Jan 17, 2025
| if (isResponseVM(element)) { | ||
| const prompt = `${e.label}: "${choices.title}"`; | ||
| const options: IChatSendRequestOptions = { | ||
| choiceData: [e.data], |
There was a problem hiding this comment.
Having trouble to understand why this is an array and not just "the item", also how is the related to madeChoice. From the usage they seem equal'ish but from the API choiceData suggests to be all data and the latter seems to be the actual choice made?
There was a problem hiding this comment.
I was following the pattern of confirmations, but I'm good making it a single object if you think it makes more sense
|
Generally looking good, have some trouble understanding what Also cc @roblourens for changes in the UI/model/etc |
These are the same thing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API similar to buttons in notifications and is a bit more flexible than the current confirmation API. It could supplant confirmation, but I left confirmation as-is for the moment. Marking this PR initially as a draft pending some discussion about awaitable choices
25-01-9af75035-5922-4948-aeff-12ee0eb2374b.mp4