address PR feedback

microsoft · Dec 16, 2024 · 783c3eb · 783c3eb
1 parent d28b027
commit 783c3eb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/chat/browser/chatInputPart.ts b/src/vs/workbench/contrib/chat/browser/chatInputPart.ts
@@ -170,7 +170,6 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
 					id: variable.id,
 					name: basename(childUri.path),
 					value: childUri,
-					kind: 'implicit',
 					isSelection: false,
 					enabled: true,
 					isFile: true,

diff --git a/src/vs/workbench/contrib/chat/browser/contrib/chatDynamicVariables.ts b/src/vs/workbench/contrib/chat/browser/contrib/chatDynamicVariables.ts
@@ -116,7 +116,9 @@ export class ChatDynamicVariableModel extends Disposable implements IChatWidgetC
 			s = [];
 		}
 
+		this.disposeVariables();
 		this._variables = [];
+
 		for (const variable of s) {
 			if (!isDynamicVariable(variable)) {
 				continue;
@@ -141,7 +143,9 @@ export class ChatDynamicVariableModel extends Disposable implements IChatWidgetC
 		// start resolving nested file references immediatelly and subscribe to updates
 		if (variable instanceof ChatFileReference && variable.isPromptSnippetFile) {
 			// subscribe to variable changes
-			variable.onUpdate(this.updateDecorations);
+			variable.onUpdate(() => {
+				this.updateDecorations();
+			});
 			// start resolving the file references
 			variable.resolve();
 		}