Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a client for Podman #222

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Add a client for Podman #222

wants to merge 35 commits into from

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Jan 24, 2024 •
edited
Loading

Closes #221

I have tested the following end-to-end (Podman v3):

  • Identity
  • ClientIdentity
  • ImageNameDefaults
  • System Commands
  • VersionCommand
  • CheckInstallCommand
  • InfoCommand
  • GetEventStreamCommand
  • LoginCommand BUSTED for Podman v3
  • LogoutCommand BUSTED for Podman v3
  • Image Commands
  • BuildImageCommand
  • ListImagesCommand
  • RemoveImagesCommand
  • PruneImagesCommand
  • PullImageCommand
  • TagImageCommand
  • InspectImagesCommand
  • PushImageCommand
  • Container Commands
  • RunContainerCommand
  • ExecContainerCommand
  • ListContainersCommand
  • StartContainersCommand
  • RestartContainersCommand
  • StopContainersCommand
  • RemoveContainersCommand
  • PruneContainersCommand
  • LogsForContainerCommand
  • InspectContainersCommand
  • ContainersStatsCommand N/A
  • Volume Commands
  • CreateVolumeCommand
  • ListVolumesCommand
  • RemoveVolumesCommand
  • PruneVolumesCommand
  • InspectVolumesCommand
  • Network Commands
  • CreateNetworkCommand
  • ListNetworksCommand
  • RemoveNetworksCommand
  • PruneNetworksCommand
  • InspectNetworksCommand
  • Context commands N/A
  • ListContextsCommand N/A
  • RemoveContextsCommand N/A
  • UseContextCommand N/A
  • InspectContextsCommand N/A
  • Filesystem commands
  • ListFilesCommand
  • StatPathCommand
  • ReadFileCommand
  • WriteFileCommand

I have tested the following end-to-end (Podman v4 via Podman Desktop):

  • Identity
  • ClientIdentity
  • ImageNameDefaults
  • System Commands
  • VersionCommand
  • CheckInstallCommand
  • InfoCommand
  • GetEventStreamCommand
  • LoginCommand
  • LogoutCommand
  • Image Commands
  • BuildImageCommand
  • ListImagesCommand
  • RemoveImagesCommand
  • PruneImagesCommand
  • PullImageCommand
  • TagImageCommand
  • InspectImagesCommand
  • PushImageCommand
  • Container Commands
  • RunContainerCommand
  • ExecContainerCommand
  • ListContainersCommand
  • StartContainersCommand
  • RestartContainersCommand
  • StopContainersCommand
  • RemoveContainersCommand
  • PruneContainersCommand
  • LogsForContainerCommand BUSTED for Podman Desktop
  • InspectContainersCommand
  • ContainersStatsCommand N/A
  • Volume Commands
  • CreateVolumeCommand
  • ListVolumesCommand
  • RemoveVolumesCommand
  • PruneVolumesCommand
  • InspectVolumesCommand
  • Network Commands
  • CreateNetworkCommand
  • ListNetworksCommand
  • RemoveNetworksCommand
  • PruneNetworksCommand
  • InspectNetworksCommand
  • Context commands N/A
  • ListContextsCommand N/A
  • RemoveContextsCommand N/A
  • UseContextCommand N/A
  • InspectContextsCommand N/A
  • Filesystem commands
  • ListFilesCommand
  • StatPathCommand
  • ReadFileCommand BUSTED for Podman Desktop
  • WriteFileCommand Couldn't test

Known issues:

  • Login fails on v3 because we lead with https://
  • Logout fails on v3 because we lead with https://
  • Container logs fails on v4 with error
  • Read files fails on v4 with error
  • Write files was not tested on v4 due to read file errors

@bwateratmsft bwateratmsft requested a review from danegsta January 24, 2024 16:07
@bwateratmsft bwateratmsft requested a review from a team as a code owner January 24, 2024 16:07
@bwateratmsft bwateratmsft requested a review from Copilot February 3, 2025 19:43
Copilot
Copilot AI reviewed Feb 3, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

packages/vscode-container-client/src/clients/PodmanClient/PodmanInspectContainerRecord.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danegsta danegsta danegsta left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a client for Podman
2 participants
@bwateratmsft @danegsta