Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blend2d] support jit on arm #43577

Closed
wants to merge 1 commit into from
Closed

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 1, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

asmjit which provides jit feature to blend2d now supports arm architecture.

@kobalicek
Copy link
Contributor

I think this is a wrong direction.

Blend2D's JIT only works on x86/x64 and aarch64, it doesn't have arm32 backend. So JIT is a feature that is by default enabled on x86/x64 and aarch64 only.

This PR basically means that users would have to specify 'jit' feature manually if they want to use Blend2D with JIT, but it's a critical feature that should always be enabled on targets that support JIT, so I would like to keep it as a default feature.

Maybe I misunderstand vcpkg, but after this change, is 'jit' enabled for x86/x64 and aarch64 by default?

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 5, 2025
@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft February 5, 2025 02:55
@MonicaLiu0311
Copy link
Contributor

but after this change, is 'jit' enabled for x86/x64 and aarch64 by default?

It will no longer be enabled by default.

@toge
Copy link
Contributor Author

toge commented Feb 6, 2025

@kobalicek
Sorry for late response.
I missed it.

I misunderstand the support architectures of blend2d.
Thank you pointing out.

Let me close this.

@toge toge closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants