Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd-cpp-apiv3] fix find cpprestsdk when build core only #43427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

waruto210
Copy link
Contributor

@waruto210 waruto210 commented Jan 23, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

etcd-cpp-apiv3 use find_dependency(cpprest), and that will return early if cpprestsdk is not found, which results in etcd-targets not being properly imported when the async feature is not enabled.

@waruto210 waruto210 force-pushed the etcd-cpp-async-feat branch from c2e85ba to e4144ab Compare January 23, 2025 13:30
@waruto210 waruto210 changed the title Etcd cpp async feat [etcd-cpp-apiv3] fix find cpprestsdk when build core only Jan 23, 2025
@waruto210 waruto210 force-pushed the etcd-cpp-async-feat branch from e4144ab to 4646217 Compare January 23, 2025 13:38
@Mengna-Li
Copy link
Contributor

Waiting for etcd-cpp-apiv3/etcd-cpp-apiv3#292.

@Mengna-Li Mengna-Li added category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project labels Jan 24, 2025
endif()

-find_dependency(cpprestsdk)
+find_package(cpprestsdk QUIET)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the incorrect fix. Instead, the patch should only call find_dependency when the async feature is enabled.

if (NOT @BUILD_ETCD_CORE_ONLY@)
  find_dependency(cpprestsdk)
endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the reminder

@waruto210 waruto210 requested a review from vicroms February 1, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants