Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql-connector-cpp] Revise, add test port #42586

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 7, 2024

Another weird CMake build system.

Reliably de-vendor third-party libs, and also remove them from this port's binaries.
Fix cross-builds (non-MSVC).
Partially reimplement the official CMake config on top of the unofficial config.

@dg0yt dg0yt force-pushed the mysql-connector-cpp branch from 16d6d66 to ebdd8cd Compare December 7, 2024 16:04
@dg0yt dg0yt marked this pull request as ready for review December 9, 2024 06:28
@FrankXie05 FrankXie05 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Dec 9, 2024
@@ -0,0 +1,61 @@
#[[
vcpkg overloads find_package().
mysql-connector-cpp overloads find_dependency().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, that is cursed

@BillyONeal BillyONeal merged commit 96b5ced into microsoft:master Dec 9, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thank you for touching the cursed and adding tests, the tests made it much easier to be confident that this would actually work!

@dg0yt dg0yt deleted the mysql-connector-cpp branch December 10, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants