[enkits] New port

[RT2Code]

Add new port enkits : https://github.com/dougbinks/enkiTS

• Changes comply with the maintainer guide
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[MonicaLiu0311]

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".

[MonicaLiu0311]

Please provide the usage file.

[RT2Code]

It should be good to go.

[MonicaLiu0311]

The name case and location issues of the config file:

1> [CMake] CMake Error at G:/enkits/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
1> [CMake]   Could not find a package configuration file provided by "unofficial-enkits"
1> [CMake]   with any of the following names:
1> [CMake] 
1> [CMake]     unofficial-enkitsConfig.cmake
1> [CMake]     unofficial-enkits-config.cmake

Edit: solved.

[MonicaLiu0311]

The usage test passed on x64-windows (header files found):

enkits provides CMake targets:

    find_package(unofficial-enkits CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::enkiTS::enkiTS)

[dg0yt]

This creates an invalid file name. You musts not use upper-case with -config.cmake. CMake only looks for <lower-case-package>config.cmake. And we do want lower-case unofficial-<port> package names.

[RT2Code]

Out of curiosity, why did you accept this PR then? I fail to see the difference with mine in this case.

[dg0yt]

... unexpected. I didn't even notice that it was a second PR. I only noticed that "unofficial" was "gone" again, and I found the config was added upstream.

[dg0yt]

The case-sensitivity problem is real: #34487, dougbinks/enkiTS#103.

[RT2Code]

Ok, thanks for the information and the fix. I used uppercase because that's what was done upstream (unreleased yet) and I hoped to be able to remove the patch on the next release, but I didn't know this could be an issue for CMake.

[dg0yt]

We also want lower-case unofficial::<port>:: here.

[dg0yt]

Doesn't upstream support shared linkage on non-win32?

[dg0yt]

... lower-case ...

[dg0yt]

unofficial::enkits::enkiTS

[dg0yt]

Suggested change

	+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/unofficial-enkiTS)
	+ DESTINATION share/unofficial-enkits)

[dg0yt]

Suggested change

	vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/unofficial-enkiTS PACKAGE_NAME unofficial-enkiTS)
	vcpkg_cmake_config_fixup(PACKAGE_NAME unofficial-enkits)

[BillyONeal]

I think this was done by #34386 ?

[RT2Code]

Yes, it's the same with minor differences due to inconsistent reviews. I'm closing it.

[MonicaLiu0311]

Duplicate of #34386.