Export mutate from @typespec/compiler/utils
#5755
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a generic function that's useful for dealing with some of the immutable types used within TypeSpec.
steverice
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
| @@ -3,5 +3,5 @@ | |||
| // Be explicit about what get exported so we don't export utils that are not meant to be public. | |||
| // --------------------------------------- | |||
| export { DuplicateTracker } from "./duplicate-tracker.js"; | |||
| export { Queue, TwoLevelMap, createRekeyableMap, deepClone, deepEquals } from "./misc.js"; | |||
| export { Queue, TwoLevelMap, createRekeyableMap, deepClone, deepEquals, mutate } from "./misc.js"; | |||
There was a problem hiding this comment.
I would be careful on how this is used as immutable types in typespec really shouldn't be changed unless you are the one managing it.
Could we update teh documentation of it to make that clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a generic function that's useful for dealing with some of the immutable types used within TypeSpec.