-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Add Typekit for @typespec/http #5340
[Experimental] Add Typekit for @typespec/http #5340
Conversation
You can try these changes here
|
What does a library consumer need to do to activate the new typekit functionality? I am a little weirded out that there doesn't seem to be any import from I think this change is righteous, just want to make sure we have the consumption pattern nailed down for these experimental APIs. I also worry a little bit about discoverability and how someone is meant to know that |
5ac71ee
to
a501795
Compare
I missed adding the export for Outside of And yes, you are right, the The concern about discoverability is valid—it's something we should address. Perhaps we can do it through the documentation or provide a more explicit activation path. I am open to suggestions if you have any thoughts on how we can better streamline this! |
@witemple-msft I dug deeper because the runtime side effects being available without explicitly loading the module was bugging me. It turns out I will add an explicit import to avoid confusion down the road |
I don't think we need to ponder this too much. When TypeKit is stabilized and then these specific extensions are stabilized, it will presumably be registered by any use of the HTTP library and that will be a good story. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This very virtuous addition looks great to me and I can't wait to try it in http-server-js and give some practical feedback on the API and add more extensions that we might need.
9e845fd
to
f6ca5ec
Compare
This PR includes:
Note: experimental/typekit subpaths were added for improved UX. The typekit import has a side effect which is augmenting existing typekit so having it within its own export isolates the side effect and makes it easier consumers to migrate once it becomes stable into
@typespec/compiler/typekit
and@typespec/http/typekit
respectively