Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: String templates #2630
Feature: String templates #2630
Changes from 23 commits
ca09099
3b9ba72
e13b6f5
ca98178
ab49c95
2eb4eb7
d1c5c04
0300483
a572001
71741b1
e027aa5
dad6fd7
ad23a85
a84c0a6
58f4802
c3b4911
f98ab52
a3f281f
16e7f8b
a4b6d9c
45c8a05
0bbe5aa
07338eb
b0101fe
f66688b
a8ace5c
f103e5a
d023fa8
36248c4
91c4fdc
9867f86
d0ae965
a9f761e
6c18405
08e7b3f
ae003dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the names look good? Alternatives could have been
TemplateString
TemplateStringLiteral
TemplateLiteral
StringTemplateLiteral
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringTemplateLiteral
is probably more accurateEDIT: Ahh, I didn't see the rest of the names. Probably don't want all of them to be
StringTemplateLiteralX
soStringTemplate
is fine IMOThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you split this into head/middle/end so that you only capture the part that needs to be computed as the middle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are technically slightly different nodes and that's how typescript also structure their template so thought be good to keep inline as they must have had a reason to do that. But right now the data inside is basically the same